fix(volo-thrift): unexpected UnexpectedEof Err returned by DefaultDec…#647
Merged
fix(volo-thrift): unexpected UnexpectedEof Err returned by DefaultDec…#647
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
==========================================
+ Coverage 43.68% 43.95% +0.27%
==========================================
Files 161 161
Lines 19679 19750 +71
==========================================
+ Hits 8596 8681 +85
+ Misses 11083 11069 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7d84c05 to
a9d220e
Compare
…oder::decode caused by non-standard behavior of shmipc sdk if a connection is closed normally
a9d220e to
b5e0aee
Compare
Millione
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oder::decode caused by non-standard behavior of shmipc sdk if a connection is closed normally
Motivation
Fix an unexpected UnexpectedEof log in volo-thrift/src/transport/pingpong/server.rs in ShmIPC mode if a ShmIPC connection is closed nomarlly.
The error return chain looks like:
Solution
If we can not read even a single byte at the very beginning of DefaultDecoder::decode in ShmIPC mode, which means we will catch a UnexpectedEof Err, it can be regarded as a normal connection close and just return Ok(None) to let volo to do some clean.